Add unit test for StandardMetadataServiceURLBuilder #8913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #8913 +/- ##
============================================
- Coverage 63.75% 63.39% -0.37%
+ Complexity 315 314 -1
============================================
Files 1169 1180 +11
Lines 49226 50061 +835
Branches 7361 7502 +141
============================================
+ Hits 31384 31736 +352
- Misses 14418 14856 +438
- Partials 3424 3469 +45
Continue to review full report at Codecov.
|
| public void testBuild() { | ||
| // test generateUrlWithoutMetadata | ||
| List<URL> urls = builder.build(new DefaultServiceInstance("test", "127.0.0.1", 8080, ApplicationModel.defaultModel())); | ||
| assertEquals(1, urls.size()); |
There was a problem hiding this comment.
You could use Hamcrest here to test the size in a more fluent way.
For example here you can write: assertThat(urls, hasSize(1));
In general this is not really necessary but since Hamcrest is in the project dependencies it would be nice to use it to make Testing more pleasing for the eye (easier reading and writing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add unit test for StandardMetadataServiceURLBuilder